[Bug 736906] wavparse: Initializing variables before using them

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736906

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #295721|none                        |needs-work
             status|                            |

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 295721
  --> https://bugzilla.gnome.org/attachment.cgi?id=295721
wavparse: Initializing uninitialized cur, stop variables

Thanks for the patch. Two more nitpicks (sorry! :))

1) I think for clarity these two should be set in the else block of if(event){
} else { ... } alongside the other bits that are set there.

2) I think in the else block stop_type should be set to GST_SEEK_TYPE_NONE
(this is unrelated to your patch I guess), I'm a bit puzzled why this wasn't a
problem so far though. If we do start_type=SET,start=0,stop_type=SET,stop=0 I
would expect it to stop immediately. I'm clearly missing something.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.