[Bug 760479] New: basesrc: Only respond to duration/position queries if the quantity is valid

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760479

            Bug ID: 760479
           Summary: basesrc: Only respond to duration/position queries if
                    the quantity is valid
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: dv at pseudoterminal.org
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 318765
  --> https://bugzilla.gnome.org/attachment.cgi?id=318765&action=edit
fix for basesrc duration&position queries

Currently, basesrc can set invalid value combinations in the duration and
position queries.

Example: duration query uses the TIME format, the basesrc only knows a
duration in BYTES of 400000 bytes, and conversion fails. However, prior to
this change, the code still answers the query, setting the format to TIME,
and the duration to 400000. This misleads downstream elements who first ask
upstream if it knows the duration in TIME format; they misinterpret the
value 400000 (which is actually the size in bytes) as a duration in TIME.

With this patch, the queries are answered only if the duration/position
value is actually valid. Downstream elements then simply get a failed
query, as opposed to a "successful" but actually invalid one.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.