[Bug 760502] New: waylandsink: Preconditon of display handle is wrong, waylandsink need to change form GST_ELEMENT_ERROR to GST_ELEMENT_WARNING in gst_wayland_sink_set_window_handle

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760502

            Bug ID: 760502
           Summary: waylandsink: Preconditon of display handle is wrong,
                    waylandsink need to change  form GST_ELEMENT_ERROR to
                    GST_ELEMENT_WARNING in
                    gst_wayland_sink_set_window_handle
    Classification: Platform
           Product: GStreamer
           Version: 1.6.1
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: hyunil46.park at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Waylandsink use "GST_ELEMENT_ERROR" In gst_wayland_sink_set_window_handle() if 
application did not provide a wayland display handle.
So gst_bus_add_watch return GST_MESSAGE_ERROR and Application can be stop.

This is a precondition that waylandsink can not use externally-supplied surface
without an externally-supplied display handle 

But this preconditon is wrong !!!.
display is only used to communicate with Wayland-server.
Waylandsink can use internal display handle which is created waylandsink.
And It is working well with externally-supplied surface.

So. we need to change LOG level from form GST_ELEMENT_ERROR to
GST_ELEMENT_WARNING in gst_wayland_sink_set_window_handle().
thank you.

diff --git a/ext/wayland/gstwaylandsink.c b/ext/wayland/gstwaylandsink.c
index f4f34a8..e2d77a9 100644
--- a/ext/wayland/gstwaylandsink.c
+++ b/ext/wayland/gstwaylandsink.c
@@ -742,10 +742,10 @@ gst_wayland_sink_set_window_handle (GstVideoOverlay *
overlay, guintptr handle)
     if (G_LIKELY (gst_wayland_sink_find_display (sink))) {
       /* we cannot use our own display with an external window handle */
       if (G_UNLIKELY (sink->display->own_display)) {
-        GST_ELEMENT_ERROR (sink, RESOURCE, OPEN_READ_WRITE,
+        GST_ELEMENT_WARNING (sink, RESOURCE, OPEN_READ_WRITE,
             ("Application did not provide a wayland display handle"),
-            ("waylandsink cannot use an externally-supplied surface without "
-                "an externally-supplied display handle. Consider providing a "
+            ("Now waylandsink use internal display handle "
+                "which is created ourselves. Consider providing a "
                 "display handle from your application with GstContext"));
       } else {
         sink->window = gst_wl_window_new_in_surface (sink->display, surface);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.