[Bug 735673] interleave: the example in the documentation does not work

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=735673

--- Comment #12 from Antonio Ospite <ao2 at ao2.it> ---
(In reply to Tim-Philipp Müller from comment #10)

> but actually I'm confused, because the previous pipeline works just fine for
> me? It's probably still a good idea to specify the positioning explicitly
> here though.
>

It now works here too indeed, I didn't re-test everything for V4. There must
have been some wavenc fixes along the way.

> I've pushed one of the wavenc test patches.
> 
> About the others:
> 
> - "tests: fix the wavenc example code to do exactly what its comment says"
> Not sure what the advantage of this change is? Why generate a file if not
> needed?
>

It was just for consistency with the comment in the file which was mentioning a
gst-launch pipeline which created the file.

I get your point tho.

> - "tests: fix the reference pipeline from the comment in the wavenc test"
> Doesn't seem to be needed though technically?
>

Right, not needed anymore.

> - "tests: improve comment in the wavenc pipeline test"
> Should be squashed/combined with previous one, if applied at all.
> 

This one was merely to put the sinks to a named element one next to the other.
IMHO this way it's easier for newcomers to understand the pipeline.

> If you attach patches individually, it's easier to track them and comment on
> them, for what it's worth. I'm going to resolve this since the original
> issue has been resolved and the rest is cosmetic as far as I can tell, but
> feel free to follow up.

As you noted the patches are not really needed, so I am not sure if it's worth
spending more time on them.

Thanks,
   Antonio

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.