[Bug 760594] decklinkvideosrc: does not support capture in RGB mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760594

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318986|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 318986:
 --> (https://bugzilla.gnome.org/review?bug=760594&attachment=318986)

Looks good in general, just some comments about (currently) unused code :)

::: sys/decklink/gstdecklink.cpp
@@ +332,3 @@
+      break;
+    case bmdFormat10BitYUV: /* 'v210' */
+      gst_structure_set (s, "format", G_TYPE_STRING, "UYVY", NULL);

v210 is "v210" and not UYVY

@@ +341,3 @@
+      break;
+    case bmdFormat10BitRGB: /* 'r210' Big-endian RGB 10-bit per component with
SMPTE video levels (64-960). Packed as 2:10:10:10 */
+      gst_structure_set (s, "format", G_TYPE_STRING, "UYVY", NULL);

"r210"

@@ +344,3 @@
+      break;
+    case bmdFormat12BitRGB: /* 'R12B' Big-endian RGB 12-bit per component with
full range (0-4095). Packed as 12-bit per component */
+      gst_structure_set (s, "format", G_TYPE_STRING, "UYVY", NULL);

We don't support this currently

@@ +347,3 @@
+      break;
+    case bmdFormat12BitRGBLE: /* 'R12L' Little-endian RGB 12-bit per component
with full range (0-4095). Packed as 12-bit per component */
+      gst_structure_set (s, "format", G_TYPE_STRING, "UYVY", NULL);

and neither this

@@ +353,3 @@
+      break;
+    case bmdFormat10BitRGBX: /* 'R10b' Big-endian 10-bit RGB with SMPTE video
levels (64-940) */
+      gst_structure_set (s, "format", G_TYPE_STRING, "UYVY", NULL);

These two would be with GST_VIDEO_COLOR_RANGE_16_235 in the colorimetry
probably (the naming is for the 8 bits range). And otherwise probably r210 for
the BE one, and unsupported for the LE one

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.