[Bug 760513] [gstbaseparse] Need push remaining data in adapter when switching to pass through mode
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jan 15 01:57:16 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=760513
--- Comment #2 from Lyon <lyon.wang at freescale.com> ---
further checking the pass through mode in h264parse.
It seems the root cause of above issue is that:
previously h264parse set passthrough flag at the negotiate in the set_caps (if
input format and alignment match negotiated output). but there is a commit
e8908f5aeef952566f6bccde743c7735d3f8c6ef , to set passthrough until at least
one keyframe has been parsed (in case the stream contains SEI messages that
supplement the output caps - for example by providing stereoscopic
information).
That means the passthrough flag will be set not in the first buffer, and if the
passthough flag is not set, the chain in buffer in gstbaseparse will be pushed
into adapter, however, when it switches to passthrough mode, there are still
data in the adapter which are not pushed to downstream. And there will be no
chance to push the remaining data in adapter in pass through mode ever after.
Resolution:
In pass through mode , should check the adapter and if there still remaining
data, need push them to downstream.
Please see attache patch for the fix.
Thanks
Lyon
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list