[Bug 760666] vp8enc: Do not mix up Booleans with FlowReturn
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jan 15 05:55:58 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=760666
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #319105|none |reviewed
status| |
--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319105:
--> (https://bugzilla.gnome.org/review?bug=760666&attachment=319105)
::: gst-libs/gst/video/gstvideoencoder.c
@@ +215,3 @@
+static void
+gst_video_encoder_release_frame (GstVideoEncoder * enc,
+ GstVideoCodecFrame * frame);
Why?
@@ +1484,3 @@
+ if (ret == GST_VIDEO_ENCODER_FLOW_DROPPED || ret == GST_FLOW_ERROR) {
+ GST_WARNING_OBJECT (encoder, "Dropping frame %p", frame);
+ gst_video_encoder_release_frame (encoder, frame);
I would be interested in why this never caused any problems so far, and what
the problems are now. I see this potentially causing new problems in old code
that assumes that the frames themselves still stay around.
@@ +1861,1 @@
gst_video_encoder_release_frame (GstVideoEncoder * enc,
Why? Looks like leftover from some experiments
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list