[Bug 760677] basesink: always drops buffers before segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760677

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
A few ideas that were discussed on IRC some time ago:

1) Add a new flag to stream-start event to identify if the stream can have its
buffers dropped or not by elements that don't fully understand the format.

2) Add flags to the caps event

3) Let basesink have a property to control that. Subclasses can automatically
set what they need.


===
Between 1 and 2 I think 2 is better because dropping or not dropping is
associated with the format and not with the stream identifier. Besides that,
the stream-start event might be created before the caps is known for some
elements or for elements that just forward the stream-start from upstream. OTOH
the stream start already has a flags field with GST_STREAM_FLAG_* stuff, having
similar flags in caps can cause some confusion.

As someone said on IRC, 3 can be implemented independently in the future to
allow users to control this by themselves but we can postpone to when needed.

There is also an idea to have an automatic mapping of caps formats to whether a
stream can drop buffers or not but this is harder to extend and maintain as
people can have their custom formats.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.