[Bug 760666] vp8enc: Do not mix up Booleans with FlowReturn

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jan 15 23:52:35 PST 2016


https://bugzilla.gnome.org/show_bug.cgi?id=760666

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319114|none                        |accepted-commit_now
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319114:
 --> (https://bugzilla.gnome.org/review?bug=760666&attachment=319114)

::: gst-libs/gst/video/gstvideoencoder.c
@@ +1483,3 @@

+  if (ret == GST_VIDEO_ENCODER_FLOW_DROPPED || ret == GST_FLOW_ERROR) {
+    GST_WARNING_OBJECT (encoder, "Dropping frame %p", frame);

I think this shouldn't be a warning but less, otherwise seems good to go

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list