[Bug 760666] vp8enc: Do not mix up Booleans with FlowReturn

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760666

--- Comment #18 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Tim-Philipp Müller from comment #17)
> Ok, if it doesn't fix anything specifically we should probably not ship it
> in 1.6.

The handling of GST_FLOW_ERROR fix a potential race with the patch I pushed on
the vp8enc.

> Also, in GstVideoDecoder we have:
> 
>   GstFlowReturn  gst_video_decoder_drop_frame (GstVideoDecoder *dec,
> 					       GstVideoCodecFrame *frame);
> 
> perhaps we should have the same in the encoder?

The doc says:

GstFlowReturn
gst_video_encoder_finish_frame (GstVideoEncoder *encoder,
                                GstVideoCodecFrame *frame);

  @frame must have a valid encoded data buffer, whose metadata fields are then
appropriately set according to frame data or no buffer at all if the frame
should be dropped. It is subsequently pushed downstream or provided to pre_push
. In any case, the frame is considered finished and released.

So I am not sure it is necessary to add another method?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.