[Bug 760821] tracerrecord: Fix memory leaks and mishandlings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760821

--- Comment #1 from Vineeth <vineeth.tm at samsung.com> ---
Created attachment 319322
  --> https://bugzilla.gnome.org/attachment.cgi?id=319322&action=edit
Fix spec structure invalid free.

self->spec is got using g_value_get_boxed(), which does not transfer the memory
and hence should not be freed.
This is resulting in the below errors.

==24380== Invalid read of size 4
==24380==    at 0x40EDFCE: gst_structure_free (gststructure.c:376)
==24380==    by 0x40FFC01: gst_tracer_record_dispose (gsttracerrecord.c:137)
==24380==    by 0x41B2237: g_object_unref (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x8049794: serialize_message_logging (gsttracerrecord.c:94)
==24380==    by 0x404FB6A: srunner_run (check_run.c:450)
==24380==    by 0x404FC22: srunner_run_all (check_run.c:674)
==24380==    by 0x4042A57: gst_check_run_suite (gstcheck.c:824)
==24380==    by 0x8048F14: main (gsttracerrecord.c:184)
==24380==  Address 0x45fb608 is 8 bytes inside a block of size 16 free'd
==24380==    at 0x402D3D8: free (in
/usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==24380==    by 0x423ED2F: g_free (in
/lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==24380==    by 0x425587A: g_slice_free1 (in
/lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==24380==    by 0x40EE0E2: gst_structure_free (gststructure.c:392)
==24380==    by 0x41D1D60: ??? (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x41AAD9D: ??? (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x41D3BF5: g_value_unset (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x41B2D15: ??? (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x41B4D96: g_object_new_valist (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x41B4FEF: g_object_new (in
/usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4002.0)
==24380==    by 0x40FFC55: gst_tracer_record_new (gsttracerrecord.c:227)
==24380==    by 0x804970D: serialize_message_logging (gsttracerrecord.c:82)
==24380==    by 0x404FB6A: srunner_run (check_run.c:450)
==24380==    by 0x404FC22: srunner_run_all (check_run.c:674)
==24380==    by 0x4042A57: gst_check_run_suite (gstcheck.c:824)
==24380==    by 0x8048F14: main (gsttracerrecord.c:184)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.