[Bug 760666] vp8enc: Do not mix up Booleans with FlowReturn
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jan 19 14:18:51 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=760666
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #319388|accepted-commit_now |needs-work
status| |
--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 319388
--> https://bugzilla.gnome.org/attachment.cgi?id=319388
videoencoder: Do not drop frame on ERROR flow
Actually this is wrong with regard to refcounting. handle_frame() takes
ownership of the frame, you must not unref it here.
I think for the DROPPED case, release_frame(ref(frame)) should be called. Which
removes the frame from the list but does not destroy it. handle_frame() should
do that if needed.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list