[Bug 760781] qtdemux: handling zero segment-duration edit list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760781

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319256|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319256:
 --> (https://bugzilla.gnome.org/review?bug=760781&attachment=319256)

::: gst/isomp4/qtdemux.c
@@ +8057,3 @@
+        /* zero duration does not imply media_start == media_stop
+         * but, only specify media_start.*/
+        stime = QTTIME_TO_GSTTIME (qtdemux, qtdemux->duration);

We might have to check if the duration is known and valid, and otherwise just
set stime to GST_CLOCK_TIME_NONE.

@@ +8059,3 @@
+        stime = QTTIME_TO_GSTTIME (qtdemux, qtdemux->duration);
+        segment->duration =
+            stime - QTSTREAMTIME_TO_GSTTIME (stream, media_time);;

Doubled semicolon here. Also you might have to check if
QTSTREAMTIME_TO_GSTTIME() returns something valid here, i.e. if media_time is
valid. Or is that ensured elsewhere already? Otherwise you might calculate with
GST_CLOCK_TIME_NONE here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.