[Bug 760774] qtdemux: fix framerate calculation for fragmented format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760774

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319248|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319248:
 --> (https://bugzilla.gnome.org/review?bug=760774&attachment=319248)

::: gst/isomp4/qtdemux.c
@@ +6944,3 @@
+        } else {
+          n_samples = stream->n_samples;
+          duration = stream->duration;

What if fragmented but duration or nsamples is unknown? Should we just not
calculate anything at all here then and don't set any framerate in the caps?

Also should the framerate (avg duration) be updated whenever a new moof is
arriving, and especially be updated in the caps too? I think this is not done
here, or is it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.