[Bug 760779] qtdemux: fix framerate calculation for fragmented format in push mode
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Jan 21 05:30:25 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=760779
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #319407|none |reviewed
status| |
--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319407:
--> (https://bugzilla.gnome.org/review?bug=760779&attachment=319407)
::: gst/isomp4/qtdemux.c
@@ +5834,3 @@
+ if (!demux->got_moov)
+ qtdemux_expose_streams (demux);
+ else {
Please add some {} around the if-case
@@ +5844,3 @@
+ demux->pending_configure = FALSE;
+ } else
+ demux->pending_configure = TRUE;
... and the else here
@@ +5909,3 @@
qtdemux_expose_streams (demux);
+ } else if (demux->pending_configure) {
+ if (!demux->exposed)
Note that the code above seems very similar (for MSS). Maybe this should all be
generalized a bit so that we always ever expose streams for fragmented MP4
after the first moof is parsed. That can probably simplify the code everywhere
a bit instead of adding yet another code path
@@ +5911,3 @@
+ if (!demux->exposed)
+ qtdemux_expose_streams (demux);
+ else {
and here
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list