[Bug 760916] gl: implement GstGLMemoryEGL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760916

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Gwang Yoon Hwang from comment #6)
> Created attachment 319491 [details]
> Updated patch
> 
> Update a patch with a bugzilla number at commit log.
> 
> For the removing GstEGLImageMemory, I found another user of
> GstEGLImageMemory.
> GstGLUpload uses GstEGLImageMemory if the src is a DMABuf.
> 
> I think it would be better to remove GstEGLImageMemory after implementing
> GstGLMemoryDMABuf.

GstGLMemoryDMABuf makes very little sense, and it does not work the way you
seem to think. In DMABuf you need to split the EGLImage from the GL texture.
The EGLImage, for performance reason, need to be attached to the original
memory containing the DMABuf, so it can be reused later. If needed though, we
can simply add a ref-counted wrapper for EGLImage. I would not want to waste a
textures and malloc just for having a ref-counted EGLImage.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.