[Bug 760270] videoparse: add support of padded video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760270

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318876|none                        |needs-work
             status|                            |

--- Comment #17 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 318876:
 --> (https://bugzilla.gnome.org/review?bug=760270&attachment=318876)

::: gst/rawparse/gstvideoparse.c
@@ +31,3 @@

+#include <stdlib.h>
+#include <stdio.h>

Why ?

@@ +302,3 @@
+{
+  return info->stride[plane] *
+      GST_VIDEO_FORMAT_INFO_SCALE_HEIGHT (info->finfo, plane, info->height);

You need a special case for nv12-64z32 . In tiled format, the stride is an
encoding of the number of tiles in x and y axis. So you extract those two
values using the macros, and then you calculate the number of tiles, multiplied
by the size of each tiles.

@@ +347,3 @@
+
+  /* 1. check that provided offsets are greaters than the default ones and is
+   * consistent with plane size */

For I420, GStreamer defaults add an empty line, which imho is acceptable no to
have. It's a minor issue though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.