[Bug 761059] kmssink: add new plugin and element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761059

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 319631:
 --> (https://bugzilla.gnome.org/review?bug=761059&attachment=319631)

::: sys/kms/gstkmssink.c
@@ +54,3 @@
+    GST_PAD_SINK,
+    GST_PAD_ALWAYS,
+    GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE (GST_VIDEO_FORMATS_ALL)));

Thanks a lot for your promptly review, Nicolas!

Agree, the formats should be taken from the explicitly supported ones.

@@ +60,3 @@
+{
+  static const char *drivers[] = { "i915", "radeon", "nouveau", "vmwgfx",
+    "exynos", "amdgpu", "imx-drm", "rockchip", "atmel-hlcdc"

Are you suggesting to use GstDeviceProvider as in v4l2???

@@ +544,3 @@
+  pool = NULL;
+  if (need_pool) {
+    if (!gst_kms_sink_ensure_pool (self, caps, size))

Can you share me a bug report or a discussion about this renegotiation fail?
Because we are using this pool caching in gstreamer-vaapi.

::: sys/kms/gstkmsutils.c
@@ +43,3 @@
+  /* DEF_FMT (XRGB1555, ???), */
+  /* DEF_FMT (XBGR1555, ???), */
+  DEF_FMT (ARGB8888, ARGB),

Thanks for the catch!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.