[Bug 761059] kmssink: add new plugin and element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761059

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Víctor Manuel Jáquez Leal from comment #4)
> Review of attachment 319631 [details] [review]:
> ::: sys/kms/gstkmssink.c
> @@ +60,3 @@
> +{
> +  static const char *drivers[] = { "i915", "radeon", "nouveau", "vmwgfx",
> +    "exynos", "amdgpu", "imx-drm", "rockchip", "atmel-hlcdc"
> 
> Are you suggesting to use GstDeviceProvider as in v4l2???

I didn't go that far in my reflection, but a DeviceProvider would fit well
here. So a combination of "device" property and a device monitor. But I would
not block merging just for that. I understand this element is mostly for
specific use case, and require per-display adaptation. So let's say if you have
time. We probably want a default that just work in any case.

> 
> @@ +544,3 @@
> +  pool = NULL;
> +  if (need_pool) {
> +    if (!gst_kms_sink_ensure_pool (self, caps, size))
> 
> Can you share me a bug report or a discussion about this renegotiation fail?
> Because we are using this pool caching in gstreamer-vaapi.

It's here, I have ported ximagesink, xvimagesink and glimagessink so far. On
the v4l2sink side, I need a bit or rework of the allocator and pool, but that's
coming. For kmssink it's trivial really. The main difference, is that instead
of checking if the GstBuffer::pool is yours, you check if the GstBuffer::pool
is of the right type.

https://bugzilla.gnome.org/show_bug.cgi?id=748344

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.