[Bug 760270] videoparse: add support of padded video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760270

Aurélien Zanelli <aurelien.zanelli at parrot.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #318876|needs-work                  |none
             status|                            |
 Attachment #318876|0                           |1
        is obsolete|                            |

--- Comment #21 from Aurélien Zanelli <aurelien.zanelli at parrot.com> ---
Created attachment 319760
  --> https://bugzilla.gnome.org/attachment.cgi?id=319760&action=edit
[3/6] videoparse: add properties to set framesize, strides and planes offsets

(In reply to Nicolas Dufresne (stormer) from comment #17)
> Review of attachment 318876 [details] [review]:
> 
> ::: gst/rawparse/gstvideoparse.c
> @@ +31,3 @@
>  
> +#include <stdlib.h>
> +#include <stdio.h>
> 
> Why ?
stdlib is needed for atoi function used to parse stride/offset string but stdio
was not needed so I remove it.

> 
> @@ +302,3 @@
> +{
> +  return info->stride[plane] *
> +      GST_VIDEO_FORMAT_INFO_SCALE_HEIGHT (info->finfo, plane, info->height);
> 
> You need a special case for nv12-64z32 . In tiled format, the stride is an
> encoding of the number of tiles in x and y axis. So you extract those two
> values using the macros, and then you calculate the number of tiles,
> multiplied by the size of each tiles.

I've done the modification, I've also change the stride update check for tiled
format. In case format is tiled I check number of tile in x and y is set by
user is greater than the defaults one.

> 
> @@ +347,3 @@
> +
> +  /* 1. check that provided offsets are greaters than the default ones and
> is
> +   * consistent with plane size */
> 
> For I420, GStreamer defaults add an empty line, which imho is acceptable no
> to have. It's a minor issue though.
I'm not sure I understand what you mean here.
Do you mean the 'empty line' added by the round up of height when it's no a
multiple of 2 ?
In this case, it seems right to do that, no ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.