[Bug 760781] qtdemux: handling zero segment-duration edit list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760781

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319583|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319583:
 --> (https://bugzilla.gnome.org/review?bug=760781&attachment=319583)

::: gst/isomp4/qtdemux.c
@@ +8019,3 @@
+              stime - QTSTREAMTIME_TO_GSTTIME (stream, media_time);
+          segment->duration =
+              segment_dur >= 0 ? segment_dur : GST_CLOCK_TIME_NONE;

This check is not doing anything: segment_dur is unsigned, so always >= 0.
Instead check before the subtraction if stime >= media_time_as_gst_clock_time.

@@ +8021,3 @@
+              segment_dur >= 0 ? segment_dur : GST_CLOCK_TIME_NONE;
+        } else
+          segment->duration = GST_CLOCK_TIME_NONE;

Add {} around this

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.