[Bug 761218] Use gst_pad_peer_query_caps() instead of using gst_pad_get_allowed_caps() to make negotiated output caps before forwarding GAP event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761218

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319890|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319890:
 --> (https://bugzilla.gnome.org/review?bug=761218&attachment=319890)

Thanks! :)

::: gst-libs/gst/audio/gstaudiodecoder.c
@@ +2025,3 @@
+  filter = gst_pad_get_pad_template_caps (dec->srcpad);
+  caps = gst_pad_peer_query_caps (dec->srcpad, filter);
+  GST_LOG_OBJECT (dec, "peer caps  %" GST_PTR_FORMAT, caps);

This will still return NULL if there is no peer. My point was that if it
returns NULL, you would just use the template caps further here.

Also the checks for empty/any caps is still needed

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.