[Bug 753899] baseparse: push sticky events to downstreams for initial prerolling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753899

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319889|none                        |needs-work
             status|                            |

--- Comment #34 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319889:
 --> (https://bugzilla.gnome.org/review?bug=753899&attachment=319889)

::: libs/gst/base/gstbaseparse.c
@@ +1083,3 @@
+
+  filter = gst_pad_get_pad_template_caps (GST_BASE_PARSE_SRC_PAD (parse));
+  peercaps = gst_pad_peer_query_caps (GST_BASE_PARSE_SRC_PAD (parse), filter);

Same comment is in the patch for audio/video decoder here :)

@@ +1399,3 @@
+        } else {
+          GST_ELEMENT_ERROR (parse, STREAM, FORMAT, (NULL),
+              ("Parser output not negotiated before GAP event."));

Here you probably want to unref the event and set it to NULL and set ret to
FALSE

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.