[Bug 761226] New: rtspmedia: Missing lock various functions (or the curious case of the duplicate unlocks)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761226

            Bug ID: 761226
           Summary: rtspmedia: Missing lock various functions (or the
                    curious case of the duplicate unlocks)
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: stevenhoving at hotmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In the following functions there is a locking issue, that is best described as
a curious case of 'duplicate unlocks'.

file: gst/rtsp-server/rtsp-media.c
functions:
- gst_rtsp_media_get_retransmission_time
- gst_rtsp_media_get_latency
- gst_rtsp_media_is_time_provider

example:
guint
gst_rtsp_media_get_latency (GstRTSPMedia * media)
{
  GstRTSPMediaPrivate *priv;
  guint res;

  g_return_val_if_fail (GST_IS_RTSP_MEDIA (media), FALSE);

  priv = media->priv;

  g_mutex_unlock (&priv->lock); // <<<<<------ should be g_mutex_lock
  res = priv->latency;
  g_mutex_unlock (&priv->lock);

  return res;
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.