[Bug 761218] Use gst_pad_peer_query_caps() instead of using gst_pad_get_allowed_caps() to make negotiated output caps before forwarding GAP event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761218

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319901|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319901:
 --> (https://bugzilla.gnome.org/review?bug=761218&attachment=319901)

::: gst-libs/gst/audio/gstaudiodecoder.c
@@ +2034,3 @@
+    gst_caps_unref (filter);
+    GST_LOG_OBJECT (dec, "peer caps  %" GST_PTR_FORMAT, caps);
+  }

No, what I mean here is:

templcaps = gst_pad_get_pad_template_caps (srcpad);
caps = gst_pad_peer_query (srcpad, templcaps);
if (caps) {
  gst_caps_unref (templcaps);
  templcaps = NULL;
} else {
  caps = templcaps;
  templcaps = NULL;
}

if (!caps || gst_caps_is_empty (caps) || gst_caps_is_any (caps))
  goto caps_error;


and then all the old code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.