[Bug 760774] qtdemux: fix framerate calculation for fragmented format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760774

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Seungha Yang from comment #8)
> - Q1: Could you please clarify your comment "But best to do that as a new
> patch on top"? Does it means report new Bug? or implement it on this patch
> set?

A separate patch, can be in this bug though.

> - Q2: I had a rethink about the second issue, and I agree with your comment
> that short first fragment might cause incorrect frame rate calculation.
> So, I modified frame rate to be updated per moof. However, based on your
> comment, you prefer averaging frame rate values over multiple fragments.
> 
> I think it is not difficult to accumulate n_samples and duration data over
> multiple moof. But I need your opinion on my following question.
> 
> - mp4 supports variable frame rate. That means, frame rate can be varied as
> time goes on. In this context, we need to choose "piecewise calculated frame
> rate" or "keep averaging frame rate". My choice is that "piecewise
> calculated frame rate" is better than the other (that's the reason why I
> implement "Modification 2"). Could you give me feedback?

Good point, I guess only averaging per moof makes sense then instead of using a
running average or so. It's just that for the first fragment it might be a bit
off but maybe that doesn't matter that much.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.