[Bug 760781] qtdemux: handling zero segment-duration edit list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760781

--- Comment #7 from Seungha Yang <sh.yang at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #5)
> Review of attachment 319583 [details] [review]:
> 
> ::: gst/isomp4/qtdemux.c
> @@ +8019,3 @@
> +              stime - QTSTREAMTIME_TO_GSTTIME (stream, media_time);
> +          segment->duration =
> +              segment_dur >= 0 ? segment_dur : GST_CLOCK_TIME_NONE;
> 
> This check is not doing anything: segment_dur is unsigned, so always >= 0.
> Instead check before the subtraction if stime >=
> media_time_as_gst_clock_time.

--> Done in patch set #3

> 
> @@ +8021,3 @@
> +              segment_dur >= 0 ? segment_dur : GST_CLOCK_TIME_NONE;
> +        } else
> +          segment->duration = GST_CLOCK_TIME_NONE;
> 
> Add {} around this

--> Done in patch set #3

Additionally in patch set #3, I declared new local variable "media_start" in
order to avoid double time unit conversion QTSTREAMTIME_TO_GSTTIME (stream,
media_time).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.