[Bug 753899] baseparse: push sticky events to downstreams for initial prerolling
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jan 29 01:47:06 PST 2016
https://bugzilla.gnome.org/show_bug.cgi?id=753899
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #319913|none |committed
status| |
--- Comment #36 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319913:
--> (https://bugzilla.gnome.org/review?bug=753899&attachment=319913)
Looks mostly good, I'll just fix up the remaining bits and merge.
::: libs/gst/base/gstbaseparse.c
@@ +893,1 @@
GST_OBJECT_UNLOCK (parse);
Unneeded whitespace change here
@@ +1061,3 @@
+ gint caps_size;
+
+ GST_LOG ("field [%s:%s]", g_quark_to_string (field_id), value_str);
I would remove the debug output here, it's not object specific and very generic
and requires additional allocation/deallocation. Just print the final caps
later :)
@@ +1408,3 @@
+ "Store caps event to pending list for initial pre-rolling");
+ parse->priv->pending_events =
+ g_list_append (parse->priv->pending_events,
This has to be prepend, not append
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list