[Bug 761211] gstpad: blocking pull probe during pull_range doesn't work

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761211

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #319884|reviewed                    |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 319884:
 --> (https://bugzilla.gnome.org/review?bug=761211&attachment=319884)

::: gst/gstpad.c
@@ +4492,3 @@
+  PROBE_PULL (pad,
+      GST_PAD_PROBE_TYPE_PULL | GST_PAD_PROBE_TYPE_BUFFER |
+      GST_PAD_PROBE_TYPE_BLOCK, res_buf, offset, size, probe_stopped);

As discussed yesterday, it should work differently and the check should be
handled like for IDLE. Basically allow PULL without any other flags being set.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.