[Bug 767641] videodecoder: Missing drain vfunc GST_FIXME flood on Raspberry Pi

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767641

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330698|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330698:
 --> (https://bugzilla.gnome.org/review?bug=767641&attachment=330698)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +2194,2 @@
     ret = gst_video_decoder_drain_out (decoder, FALSE);
+    GST_VIDEO_DECODER_STREAM_UNLOCK (decoder);

If I'm not missing anything, chain_forward() is always called with that lock
taken already: from _chain() which takes it just around, and _flush_parse() is
called from _drain_out() (!) for reverse playback and _chain_reverse() which is
called with the lock taken in _chain().

@@ +2232,2 @@
       gst_video_decoder_drain_out (decoder, FALSE);
+      GST_VIDEO_DECODER_STREAM_UNLOCK (decoder);

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.