[Bug 767900] multipartmux is not clearing dts timestamp.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767900

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330239|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330239:
 --> (https://bugzilla.gnome.org/review?bug=767900&attachment=330239)

::: gst/multipart/multipartmux.c
@@ +312,3 @@

+  if (old->dts_timestamp != GST_CLOCK_TIME_NONE &&
+      new->dts_timestamp != GST_CLOCK_TIME_NONE) {

Basically this comparison here should do something like
GST_BUFFER_DTS_OR_PTS(), that is using the one that is not NONE

@@ +316,3 @@
+    /* no timestamp on old buffer, it must go first */
+    oldtime = old->dts_timestamp;
+    if (oldtime == GST_CLOCK_TIME_NONE)

This does not make sense: above you check that it is != NONE

@@ +496,3 @@

+    if (best->pts_timestamp != -1)
+      time = best->pts_timestamp;

Should this maybe be
  time = dts != NONE ? dts : (pts != NONE ? pts : 0)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.