[Bug 768268] qtdemux: Push caps only when it was updated

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768268

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330702|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330702:
 --> (https://bugzilla.gnome.org/review?bug=768268&attachment=330702)

::: gst/isomp4/qtdemux.c
@@ +7531,3 @@
     }
+
+    if (!prev_caps || !gst_caps_is_equal_fixed (prev_caps, stream->caps)) {

Wouldn't it be better to just get prev_caps here? Then you don't need to carry
it around all the time and unref it in all return paths but just have it
locally here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.