[Bug 768232] rtspsrc protocols aren't restarted after rtsp redirect

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768232

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330680|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330680:
 --> (https://bugzilla.gnome.org/review?bug=768232&attachment=330680)

::: gst/rtsp/gstrtspsrc.c
@@ +4890,3 @@
+   * try TCP when we were configured with an SDP. */
+  if(!src->need_redirect) {
+    if (!(src->protocols & GST_RTSP_LOWER_TRANS_TCP) || src->from_sdp)

These two ifs could be combined into one

@@ +4898,3 @@
+        GST_ELEMENT_WARNING (src, RESOURCE, READ, (NULL),
+        ("RTSP redirect occurred after %.4f seconds.",
+            gst_guint64_to_gdouble (src->udp_timeout / 1000000.0)));

Why a warning on redirect? That's not really a problem, is it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.