[Bug 765798] vaapisink: add support for GST_TAG_IMAGE_ORIENTATION

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765798

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330699|none                        |needs-work
             status|                            |

--- Comment #10 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 330699:
 --> (https://bugzilla.gnome.org/review?bug=765798&attachment=330699)

::: gst/vaapi/gstvaapisink.c
@@ +1794,3 @@
+      "Select to set orientation based on image-orientation tag
automatically",
+      TRUE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
+

Sorry, I didn't  explain myself correctly.

We should be very careful when we add new interfaces to the user. I don't see
the need to add another knob for this feature.

Right now vaapisink has a property for rotation:

rotation            : The display rotation mode
                        flags: readable, writable
                        Enum "GstVaapiRotation" Default: 0, "0"
                           (0): 0                - Unrotated mode
                           (90): 90               - Rotated by 90°, clockwise
                           (180): 180              - Rotated by 180°, clockwise
                           (270): 270              - Rotated by 270°, clockwise

The idea, then, is to mimic videoflip's property "method". This is, to add a
new item in the rotation enum, called "automatic", which will enable this
feature.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.