[Bug 768301] Add explicit setters and getters for GstBufferFlags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768301

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330754|none                        |reviewed
             status|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 330754
  --> https://bugzilla.gnome.org/attachment.cgi?id=330754
Proposed patch

Thanks for the patch, I think this makes sense. Couple of comments:

 - (transfer none) doesn't make sense for booleans and integer types

 - please add "Since: 1.10" markers at the end of each gtk-doc blob

 - not quite sure about naming, in particular:

     - gst_buffer_flags() -> gst_buffer_get_flags() ?

     - gst_buffer_flag_set() -> gst_buffer_set_flags() ? [can set multiple in
one go]

     - gst_buffer_flag_unset() -> gst_buffer_unset_flags() ? [ditto]

     - gst_buffer_flag_is_set() -> gst_buffer_check_flags() _has_flags()
is_flag_set? [not sure]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.