[Bug 768301] Add explicit setters and getters for GstBufferFlags

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768301

--- Comment #2 from Arjen Veenhuizen <arjen.veenhuizen at tno.nl> ---
Hi Tim,

Thanks for your feedback!


 - (transfer none) doesn't make sense for booleans and integer types --> fixed

 - please add "Since: 1.10" markers at the end of each gtk-doc blob --> added

 - not quite sure about naming, in particular:

     - gst_buffer_flags() -> gst_buffer_get_flags() ? --> changed

     - gst_buffer_flag_set() -> gst_buffer_set_flags() ? [can set multiple in
one go] --> changed

     - gst_buffer_flag_unset() -> gst_buffer_unset_flags() ? [ditto] -->
changed

     - gst_buffer_flag_is_set() -> gst_buffer_check_flags() _has_flags()
is_flag_set? [not sure] --> changed

At first I tried to keep the method names in sync with the macro names, but I
agree that your proposed method names are more clear. I will upload a new patch
in a couple of minutes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.