[Bug 768450] pad: check caps not NULL before referring

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jul 5 16:38:11 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768450

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330909|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330909:
 --> (https://bugzilla.gnome.org/review?bug=768450&attachment=330909)

::: gst/gstpad.c
@@ +2759,2 @@
   query = gst_query_new_caps (mycaps);
   gst_pad_peer_query (pad, query);

It should rather check if this returns TRUE or not. If it does, we use the caps
(and they must be non-NULL). Otherwise we just go out.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list