[Bug 768450] pad: check caps not NULL before referring

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768450

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330914|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330914:
 --> (https://bugzilla.gnome.org/review?bug=768450&attachment=330914)

::: gst/gstpad.c
@@ +2767,3 @@
+    gst_caps_ref (caps);
+  } else {
+    g_warning ("Caps are NULL");

That's not useful information when printed later :) Make this a "g_warn_if_fail
(caps != NULL)", which is a double-check then but will print the assertion and
also source file and line.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.