[Bug 768446] kmssink: on intel, stride must be 64 byte aligned

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768446

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #1)
> Would it be possible to clarify who picked this stride ? 

GstVideoInfo generate that value.

AddFB2 is called in the gstkmsallocator and the stride/pitch is set with 

pitches[i] = GST_VIDEO_INFO_PLANE_STRIDE (vinfo, i); 

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/sys/kms/gstkmsallocator.c#n327

> Ideally, their
> should be a kernel API that provides the requires stride for a certain
> width. 

Are you saying that we should not fill that value?? 

> If we instead get the alignment info, we can use GstVideoAlignement +
> gst_video_info_align() to calculate the required stride.
> gst_video_frame_copy() is safe for when you can't match the buffer stride
> with requirement. It will handle copied with different strides.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.