[Bug 768467] avidemux: do not increase num_streams when parse_stream fail

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 7 07:13:58 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768467

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330930|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330930:
 --> (https://bugzilla.gnome.org/review?bug=768467&attachment=330930)

This does not seem correct. The num_streams counter seems to be also used for
knowing the "stream index", i.e. see the index handling in that function.

If a stream is skipped because it fails parsing, we should probably make sure
that using it elsewhere is just ignoring it instead of crashing later.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list