[Bug 768249] rtspsrc lockup on gst_rtspsrc_stop

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768249

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330857|none                        |reviewed
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330857:
 --> (https://bugzilla.gnome.org/review?bug=768249&attachment=330857)

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +2162,3 @@
   }
 done:
+  conn->may_cancel = TRUE;

This seems to defeat the purpose of this may_cancel flag. If you end up here
because STATE_START and then STATE_DATA_HEADER/READ_LINES, and then no more
data is there until the next iteration, it would go out here.

The intention of the flag seems to be to not allow interruptions in the middle
of RTSP messages (why?!) and at the end of the message it will go to STATE_END
where may_cancel is set to TRUE again.


Where does it end up for you, what's the events that lead to reading being
called without timeout/cancellable?

@@ +2168,3 @@
 invalid_body_len:
   {
+    conn->may_cancel = TRUE;

This one probably makes sense, but after this the connection is unusable
anyway, right?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.