[Bug 768509] matroskamux: Segmentation fault in string comparison

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768509

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330988|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330988:
 --> (https://bugzilla.gnome.org/review?bug=768509&attachment=330988)

::: gst/matroska/matroska-mux.c
@@ +3569,3 @@

+  if (!g_strcmp0 (collect_pad->track->codec_id,
+          GST_MATROSKA_CODEC_ID_AUDIO_OPUS)

Question is why this is NULL in the first place, and why we didn't error out
earlier because of that already. We probably should :)

Same goes for the other commit you mentioned.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.