[Bug 753760] rtph265: sync against latest spec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753760

--- Comment #17 from Jonas Holmberg <jonas.holmberg at axis.com> ---
(In reply to Sebastian Dröge (slomo) from comment #16)
> (In reply to Jonas Holmberg from comment #15)
> > (In reply to Sebastian Dröge (slomo) from comment #14)
> > > Review of attachment 330940 [details] [review] [review] [review]:
> > > 
> > > ::: gst/rtp/gstrtph265depay.c
> > > @@ +775,3 @@
> > > +    ps = NULL;
> > > +  } else {
> > > +    ps = g_strdup_printf ("%s,%s,%s", vps, sps, pps);
> > > 
> > > It would probably be nicer to split this code apart so that each structure
> > > is parsed independently instead of concatenating them all together just to
> > > tear them apart again
> > 
> > Yes, I agree. But I was thinking that it could be done in a later commit
> > since it requires a bit of refactoring?
> 
> Probably not too much though? The first thing that happens a few lines below
> in all cases is "params = g_strsplit (ps, ",", 0);"
> 
> You could just fill this params array instead of first creating the string

Each of these (vps, sps and pps) can also be a comma separated list.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.