[Bug 768525] subparse: don't reset allowed tags

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 7 15:47:19 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768525

--- Comment #1 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Created attachment 331004
  --> https://bugzilla.gnome.org/attachment.cgi?id=331004&action=edit
subparse: don't reset allowed tags

When a discont buffer is processed, the state is re-initialized, which
nullifies the allowed_tags.

The problem is when a subrip string with tags is processed and allowed_tags is
NULL. The function subrip_unescape_formatting() calls g_strjoinv with a
str_array as NULL, leading to a GLib-CRITICAL.

This patch removes the allowed_tags resetting, in parser_state_init(), but
move it into gst_sub_parse_format_autodetect().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list