[Bug 768530] shmsink: Check return values of functions operating on memory

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 7 19:06:26 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768530

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331015|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 331015:
 --> (https://bugzilla.gnome.org/review?bug=768530&attachment=331015)

::: sys/shm/gstshmsink.c
@@ +722,3 @@
+    if (!gst_memory_map (memory, &map, GST_MAP_WRITE)) {
+      GST_ELEMENT_ERROR (self, STREAM, FAILED,
+          (NULL),

The first string is the most important, please swap.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list