[Bug 747275] jackaudiosink: hangs when jackd exits

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747275

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330654|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330654:
 --> (https://bugzilla.gnome.org/review?bug=747275&attachment=330654)

::: ext/jack/gstjackaudioclient.c
@@ +600,3 @@
   /* make sure that we are not dispatching the client */
   g_mutex_lock (&client->conn->lock);
+  if (client->active && !active && client->server_down == FALSE) {

Don't test booleans for equality. Do "!client->server_down" here.

But isn't this racy? What if it's just getting set to TRUE right after we did
the check?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.