[Bug 767862] leaks tracer: display creation stack trace of leaked objects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767862

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330304|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330304:
 --> (https://bugzilla.gnome.org/review?bug=767862&attachment=330304)

::: plugins/tracers/gstleaks.c
@@ +241,3 @@
+#ifdef HAVE_BACKTRACE
+  return generate_backtrace_trace ();
+#endif /* HAVE_BACKTRACE */

What if we have both? Then we have unreachable code here and compile both in :)

@@ +356,3 @@
   leak->ref_count = ref_count;
   leak->desc = gst_info_strdup_printf ("%" GST_PTR_FORMAT, obj);
+  leak->trace = trace;

Is this guaranteed to be a valid pointer long enough, or should it be strdup()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.