[Bug 768602] New: EGL_DMA_Buf: Wrong attribute list type for EGL 1.5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768602

            Bug ID: 768602
           Summary: EGL_DMA_Buf: Wrong attribute list type for EGL 1.5
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: kevinbing.song at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Below attribute list type is wrong for EGL 1.5. It is right for EGL version
below 1.5.

GstEGLImage *
gst_egl_image_from_dmabuf (GstGLContext * context,
    gint dmabuf, GstVideoInfo * in_info, gint plane, gsize offset)
{
  ...
  EGLint attribs[13];
...
}

For EGL 1.5 spec, the attribute list type should be EGLAttrib. EGLAttrib is
same as intptr_t. intptr_t will be 64bit type on 64bit system. So create EGL
image from DMA Buf FD will fail and then fall back to raw data upload.

Below is the state in GEL 1.5 spec:

"EGLAttrib is  an  integral  type  defined  to  be  equivalent  to  the  ISO  C
intptr_t type. It  is  used  in  the  commands eglCreateImage, eglCreateSync,
eglCreatePlatformWindowSurface, eglCreatePlatformPixmapSurface,
eglGetPlatformDisplay,  and eglGetSyncAttrib,  and  will  be  used  for  all
similar commands in the future which take attribute lists or return attribute
values, since such commands might at some point need to represent handle and
pointer values in attribute lists as well as other integral types"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.