[Bug 767712] xvimage: Missing sanity checking for allocation sizes for various video formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767712

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330994|none                        |needs-work
             status|                            |

--- Comment #31 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330994:
 --> (https://bugzilla.gnome.org/review?bug=767712&attachment=330994)

::: sys/xvimage/xvimageallocator.c
@@ +344,3 @@
 gst_xvimage_allocator_alloc (GstXvImageAllocator * allocator, gint im_format,
+    const GstVideoInfo * info, gint padded_width, gint padded_height,
+    GstVideoRectangle * crop, GError ** error)

Might want to make the crop rectangle also const ;)

@@ +440,2 @@
       }
+    } else if (GST_VIDEO_FORMAT_INFO_IS_RGB (info->finfo)) {

This will break with the GBR (planar RGB) formats, maybe check for a single
plane in addition to this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.