[Bug 768510] appsrc: handle pushing custom segments

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768510

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Seungha Yang from comment #8)
> (In reply to Sebastian Dröge (slomo) from comment #7)
> > Review of attachment 331151 [details] [review] [review]:
> > 
> > Thanks, this looks like a good start :) We should double-check if the
> > seamless segment API of basesrc does the right thing though, it was
> > implemented for a completely different use-case. That's why it has the
> > "seamless" in the name. This here is not really for anything seamless
> > anymore.
> 
> Thanks for your detailed review.
> Frankly, the "seamless" is confusing me because it's used only dvb related
> element, (I've never use it....). Can I ask why it's called seamless? (in
> the sense the SEGMENT for seamless playback?)
> [...]

It seems to do exactly what we need here, so let's use it :) It's going to
output the new segment right before the next data.

> > @@ +804,3 @@
> > +   * - Application has been notified that it can control pipeline timeline
> > +   *   (by setting 'driven-by-application' property)
> > +   * - Both appsrc segment and the custom segment have TIME format
> > 
> > BYTES format and BYTES segment and other compatible pairs should also work
> > though
> 
> I'll try to support BYTES format and BYTES segment, but could you explain
> more about compatible pairs?

The segment format must be the same as the value of the format property on
appsrc. That's what I meant.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.